-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): support wrapper classes for Java basic types #278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 68.87% 70.09% +1.21%
==========================================
Files 26 27 +1
Lines 2911 3016 +105
==========================================
+ Hits 2005 2114 +109
+ Misses 683 677 -6
- Partials 223 225 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mulavar use Encoder to test encode in unit tests please.
e9dc06c
to
b470210
Compare
@Mulavar thanks for your effort. wrapper classes is mainly for java, so the unit test should contains cross language encode/decode. Pls pay more time to do that, thanks very much! eg: go encode -> java decode:
java encode-> go decode:
|
fff58ca
to
9aafe3b
Compare
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: