Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil slice decoding to empty slice #318

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Conversation

mark4z
Copy link
Member

@mark4z mark4z commented Jul 3, 2022

What this PR does:
#317
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #318 (097671a) into master (ca7b2ca) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   70.44%   70.47%   +0.02%     
==========================================
  Files          27       27              
  Lines        3116     3119       +3     
==========================================
+ Hits         2195     2198       +3     
  Misses        687      687              
  Partials      234      234              
Impacted Files Coverage Δ
list.go 85.71% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7b2ca...097671a. Read the comment docs.

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 83d6845 into apache:master Jul 4, 2022
@wongoo wongoo changed the title nil slice decode to empty slice fix nil slice decoding to empty slice Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants