fix Decoder failed to decode int8/int16 type values of map field in struct #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Map with int8/int16 as key or value type
ahaostudy
changed the title
tiltwind
reviewed
Nov 1, 2023
map_test.go
Outdated
| if err != nil { | ||
| t.Errorf("Decode() = %+v", err) | ||
| } | ||
| t.Logf("decode(%v) = %v, %v\n", obj, res, err) |
There was a problem hiding this comment.
should check whether the decode value is equal to the original
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 68.98% 69.23% +0.24%
==========================================
Files 28 28
Lines 3140 3146 +6
==========================================
+ Hits 2166 2178 +12
+ Misses 751 745 -6
Partials 223 223
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wongoo
approved these changes
Nov 1, 2023
jasondeng1997
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix Decoder failed to decode int8/int16 type values of map field in struct
Which issue(s) this PR fixes:
Currently, dubbo-go-hessian2 is unable to correctly decode values of type
int8/int16that are contained within amaptype field in a struct, resulting in a panic during the decoding process.This PR is intended to fix this issue, which will enhance the compatibility between dubbo-go and dubbo-java.
Special notes for your reviewer:
I am a developer of the Kitex framework, and currently, DubboCodec is utilizing dubbo-go-hessian2 as its encoder/decoder. We also hope to resolve this issue through this PR, enabling us to support decoding of
int8andint16types.Does this PR introduce a user-facing change?: