Feature/add decimal support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongoo
reviewed
Jul 6, 2019
|
@aliiohs I think just add Decimal as a POJO, do not refactor the hessian2 to meet it, change the Decimal instead. And also add unit test to decode that encoded in java. |
gaoxinge
reviewed
Jul 7, 2019
wongoo
reviewed
Jul 8, 2019
gaoxinge
approved these changes
Jul 8, 2019
|
Nice work. |
wongoo
reviewed
Jul 9, 2019
wongoo
reviewed
Jul 9, 2019
object.go
Outdated
| @@ -346,7 +346,7 @@ func (d *Decoder) decInstance(typ reflect.Type, cls classInfo) (interface{}, err | |||
| d.unreadByte() // Enum parsing, decInt64 above has read a byte, so you need to return a byte here | |||
| s, err := d.DecodeValue() | |||
| if err != nil { | |||
| return nil, perrors.Wrapf(err, "decInstance->decObject field name:%s", fieldName) | |||
| return nil, perrors.Wrapf(err, "decInstance->Deserialize field name:%s", fieldName) | |||
There was a problem hiding this comment.
I think it doesn't needed to change the comment.
There was a problem hiding this comment.
Isn't the name consistent?
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
Feature/add decimal support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Feature/add decimal support
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: