Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix findHttpManager #193

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Conversation

LvBay
Copy link
Contributor

@LvBay LvBay commented Jun 23, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #192

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #193 (18bf28e) into develop (da865b0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #193   +/-   ##
========================================
  Coverage    38.09%   38.09%           
========================================
  Files           36       36           
  Lines         1848     1848           
========================================
  Hits           704      704           
  Misses        1048     1048           
  Partials        96       96           
Impacted Files Coverage Δ
pkg/pixiu/listener.go 19.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da865b0...18bf28e. Read the comment docs.

@AlexStocks AlexStocks merged commit 70e6fb7 into apache:develop Jul 1, 2021
@xiaoliu10 xiaoliu10 added this to the v0.3.0 milestone Jul 2, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
fix findHttpManager

Former-commit-id: 70e6fb7
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
fix findHttpManager

Former-commit-id: ff556f0 [formerly 70e6fb7]
Former-commit-id: 66934a8
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interface {} is model.HttpConnectionManager, not *model.HttpConnectionManager
5 participants