Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixBug: can't delete node by path #201

Merged
merged 10 commits into from
Jul 4, 2021
Merged

FixBug: can't delete node by path #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5b09deb
Merge pull request #1 from apache/develop
ztelur Apr 13, 2021
d807c83
Merge branch 'apache:develop' into develop
ztelur May 17, 2021
fc4a311
Merge branch 'apache:develop' into develop
ztelur Jun 14, 2021
da57025
Merge branch 'apache:develop' into develop
ztelur Jun 24, 2021
4d736dd
Merge branch 'apache:develop' into develop
ztelur Jun 25, 2021
31515c8
Merge branch 'apache:develop' into develop
ztelur Jul 1, 2021
170eeb0
fix bug can't delete node
ztelur Jul 1, 2021
9a35acf
Merge branch 'apache:develop' into develop
ztelur Jul 1, 2021
7428b48
rm return statement
ztelur Jul 2, 2021
23f2104
Merge branch 'develop' of https://github.com/ztelur/dubbo-go-pixiu in…
ztelur Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/config/api_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,8 @@ func listenResourceAndMethodEvent(key string) bool {
case mvccpb.DELETE:
logger.Infof("get event (key{%s}) = event{EventNodeDeleted}", event.Kv.Key)
handleDeleteEvent(event.Kv.Key, event.Kv.Value)
return true
default:
return false
logger.Infof("get event (key{%s}) = event{%d}", event.Kv.Key, event.Type)
}
}
}
Expand Down
11 changes: 4 additions & 7 deletions pkg/router/route.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,10 @@ func (rt *Route) FindAPI(fullPath string, httpverb config.HTTPVerb) (*router.API
// DeleteNode delete node by fullPath
func (rt *Route) DeleteNode(fullPath string) bool {
lowerPath := strings.ToLower(fullPath)
if _, found := rt.searchWildcard(lowerPath); found {
rt.lock.RLock()
defer rt.lock.RUnlock()
rt.tree.Remove(lowerPath)
return true
}
return false
rt.lock.RLock()
defer rt.lock.RUnlock()
rt.tree.Remove(lowerPath)
return true
}

// DeleteAPI delete api by fullPath and http verb
Expand Down