Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich filter test case #202

Merged
merged 6 commits into from
Jul 5, 2021
Merged

Enrich filter test case #202

merged 6 commits into from
Jul 5, 2021

Conversation

tydhot
Copy link
Member

@tydhot tydhot commented Jul 1, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #202 (422c26d) into develop (2b4af4d) will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    36.45%   37.54%   +1.09%     
===========================================
  Files           36       39       +3     
  Lines         1934     1987      +53     
===========================================
+ Hits           705      746      +41     
- Misses        1134     1143       +9     
- Partials        95       98       +3
Impacted Files Coverage Δ
pkg/filter/logger/logger.go 75.00% <0.00%> (ø)
pkg/filter/authority/authority.go 80.95% <0.00%> (ø)
pkg/filter/header/header.go 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4af4d...422c26d. Read the comment docs.

@tydhot
Copy link
Member Author

tydhot commented Jul 2, 2021

@AlexStocks The imports is spilted now:)

@AlexStocks AlexStocks merged commit 9c3b199 into apache:develop Jul 5, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@AlexStocks
Merge pull request #202 from tydhot/0701unittest
2b997bf 
Enrich filter test case

Former-commit-id: 9c3b199
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@AlexStocks
Merge pull request apache#202 from tydhot/0701unittest
6f0f4eb 
Enrich filter test case

Former-commit-id: 2b997bf [formerly 9c3b199]
Former-commit-id: fb5de39
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@AlexStocks
Merge pull request apache#202 from tydhot/0701unittest
25e5652 
Enrich filter test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoliu10 xiaoliu10 xiaoliu10 approved these changes

@williamfeng323 williamfeng323 williamfeng323 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tydhot @codecov-commenter @AlexStocks @williamfeng323 @xiaoliu10