Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for grpc invoke service provider #244

Merged
merged 25 commits into from
Sep 18, 2021

Conversation

MasterKenway
Copy link
Contributor

What this PR does:
Support for grpc invoke service provider
Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@MasterKenway MasterKenway force-pushed the feat/grpc branch 2 times, most recently from 0ead84e to 49dd749 Compare September 6, 2021 17:15
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #244 (fc93872) into develop (f1836e0) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    40.93%   40.18%   -0.76%     
===========================================
  Files           51       50       -1     
  Lines         2587     2541      -46     
===========================================
- Hits          1059     1021      -38     
+ Misses        1415     1410       -5     
+ Partials       113      110       -3     
Impacted Files Coverage Δ
pkg/server/listener.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1836e0...fc93872. Read the comment docs.

@MasterKenway MasterKenway marked this pull request as ready for review September 6, 2021 17:36
Copy link
Contributor

@ztelur ztelur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewdog 的评论修改一下

@MasterKenway
Copy link
Contributor Author

reviewdog 的评论修改一下

已修改

@mark4z
Copy link
Member

mark4z commented Sep 18, 2021

resolve conflict pls

@MasterKenway
Copy link
Contributor Author

resolve conflict pls

done

@AlexStocks AlexStocks merged commit 1052eaa into apache:develop Sep 18, 2021
@ztelur ztelur added this to the v0.4.0 milestone Oct 20, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
Feat: Support for grpc invoke service provider
Former-commit-id: 1052eaa
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Feat: Support for grpc invoke service provider
Former-commit-id: 0b2661f [formerly 1052eaa]
Former-commit-id: 940f656
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Feat: Support for grpc invoke service provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants