fix：POST request body is missing

[baerwang]

What this PR does:

Which issue(s) this PR fixes:

Fixes #259

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[ztelur]

Filter struct {
  cfg *Config
  client *http3.Client
}

is this way better ? leave config empty for adding more config property for httpclient further

[dk-lockdown]

不应将整个 http.Client 给用户反序列化配置，用户只需要关注 transport 的内容

[baerwang]

我想的是把整个http.Client交给用户，http.Clinet 里的其它的配置也许用户需要用呢？

[dk-lockdown]

transport 是一个 interface，直接反序列化 client 怎么样知道 transport 反序列化到哪个对象上呢。

[baerwang]

我不太明白你说的反序列化client场景的所在的意义，如果以为有这个必要的话，我可以重新提交pr

[dk-lockdown]

func (fm *FilterManager) Apply(name string, conf map[string]interface{}) (HttpFilter, error) {
	plugin, err := GetHttpFilterPlugin(name)
	if err != nil {
		return nil, errors.New("filter not found")
	}

	filter, err := plugin.CreateFilter()

	if err != nil {
		return nil, errors.New("plugin create filter error")
	}

	factoryConf := filter.Config()
        //filter 的 config 是通过 yaml 反序列化去初始化的。
	if err := yaml.ParseConfig(factoryConf, conf); err != nil {
		return nil, errors.Wrap(err, "config error")
	}
	err = filter.Apply()
	if err != nil {
		return nil, errors.Wrap(err, "create fail")
	}
	return filter, nil
}

见上面代码注释

[baerwang]

好的，那我把transport放到filter结构体下，保证当前该代码的统一风格，有问题嘛

[dk-lockdown]

这样应该没问题

[baerwang]

Filter struct {
  cfg *Config
  client *http3.Client
}

这种方式更好吗？将配置留空以进一步为 httpclient 添加更多配置属性

我觉得可以，另外这种还可以保证代码的统一规范

[codecov-commenter]

Codecov Report

Merging #260 (d374a53) into develop (6a282f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #260   +/-   ##
========================================
  Coverage    39.75%   39.75%           
========================================
  Files           50       50           
  Lines         2568     2568           
========================================
  Hits          1021     1021           
  Misses        1436     1436           
  Partials       111      111           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a282f0...d374a53. Read the comment docs.