Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil issue for timeout filter. #278

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

awayings
Copy link
Contributor

What this PR does:
nil issue when timeout filter is configured into pixiu
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #278 (cc58e71) into develop (7234723) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #278   +/-   ##
========================================
  Coverage    33.13%   33.13%           
========================================
  Files           62       62           
  Lines         3323     3323           
========================================
  Hits          1101     1101           
  Misses        2108     2108           
  Partials       114      114           
Impacted Files Coverage Δ
pkg/filter/timeout/timeout.go 56.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7234723...cc58e71. Read the comment docs.

@ztelur ztelur merged commit 8cb296a into apache:develop Oct 14, 2021
mark4z added a commit that referenced this pull request Nov 7, 2021
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Former-commit-id: 8cb296a
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Former-commit-id: de8f95f [formerly 8cb296a]
Former-commit-id: e600ed9
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants