using trie enhance dubbo route.go #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #310 +/- ##
===========================================
+ Coverage 36.52% 36.80% +0.28%
===========================================
Files 54 54
Lines 3253 3260 +7
===========================================
+ Hits 1188 1200 +12
+ Misses 1945 1937 -8
- Partials 120 123 +3
Continue to review full report at Codecov.
|
|
plz fix ci problem |
AlexStocks
reviewed
Dec 1, 2021
AlexStocks
reviewed
Dec 1, 2021
AlexStocks
reviewed
Dec 1, 2021
PhilYue
reviewed
Dec 1, 2021
ztelur
reviewed
Dec 15, 2021
| if strings.HasSuffix(ret, constant.PathSlash) { | ||
| ret = ret[0 : len(ret)-1] | ||
| } | ||
| ret = strings.Split(ret, "?")[0] |
There was a problem hiding this comment.
is it better to make "?" as a constant named variable? code in trie.go uses "?" too
| ) | ||
|
|
||
| import ( | ||
| "github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil" | ||
| "github.com/apache/dubbo-go-pixiu/pkg/logger" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
please split third party import to another import block,like below.
import (
"github.com/apache/dubbo-go-pixiu/pkg/common/util/stringutil"
"github.com/apache/dubbo-go-pixiu/pkg/logger"
)
import (
"github.com/pkg/errors""
)
ztelur
approved these changes
Dec 15, 2021
PhilYue
approved these changes
Dec 18, 2021
AlexStocks
approved these changes
Dec 19, 2021
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go * using trie enhance dubbo route.go Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: randy <ztelur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using trie enhance dubbo route.go