Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #461] fix response header Content-Type #462

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

victory460
Copy link

What this PR does:

Which issue(s) this PR fixes: #461

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@victory460 victory460 changed the title fix response header Content-Type [ISSUE #461] fix response header Content-Type Aug 2, 2022
@AlexStocks
Copy link
Contributor

是不是得针对这个功能补充一个文档?或者一段文字放在 readme 里面?

@victory460
Copy link
Author

是不是得针对这个功能补充一个文档?或者一段文字放在 readme 里面?

好嘞,您看补充一段文字到这个README 如何? @AlexStocks

@victory460 victory460 force-pushed the feature_content_type branch from aa3b8df to a71cde6 Compare August 3, 2022 03:06
@AlexStocks
Copy link
Contributor

是不是得针对这个功能补充一个文档?或者一段文字放在 readme 里面?

好嘞,您看补充一段文字到这个README 如何? @AlexStocks

可以。

@codecov-commenter
Copy link

Codecov Report

Merging #462 (a71cde6) into develop (28e040d) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
- Coverage    37.26%   37.20%   -0.06%     
===========================================
  Files           56       56              
  Lines         3805     3811       +6     
===========================================
  Hits          1418     1418              
- Misses        2224     2230       +6     
  Partials       163      163              
Impacted Files Coverage Δ
pkg/common/http/manager.go 42.85% <0.00%> (-1.74%) ⬇️
pkg/context/http/context.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mark4z
Copy link
Member

mark4z commented Aug 3, 2022

LGTM

@mark4z
Copy link
Member

mark4z commented Aug 3, 2022

Good job

@victory460 victory460 force-pushed the feature_content_type branch from a71cde6 to cf9cf23 Compare August 3, 2022 09:15
@victory460
Copy link
Author

是不是得针对这个功能补充一个文档?或者一段文字放在 readme 里面?

好嘞,您看补充一段文字到这个README 如何? @AlexStocks

可以。

done.

@victory460 victory460 force-pushed the feature_content_type branch from cf9cf23 to ce9145a Compare August 3, 2022 11:06
@victory460 victory460 requested a review from AlexStocks August 3, 2022 11:08
@AlexStocks AlexStocks merged commit cbf006f into apache:develop Aug 3, 2022
@PhilYue PhilYue added this to the 0.6.0 milestone Aug 3, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants