WASM Plugin for Pixiu #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilYue
approved these changes
Aug 19, 2022
baerwang
approved these changes
Aug 19, 2022
cityiron
reviewed
Aug 20, 2022
mark4z
reviewed
Aug 20, 2022
mark4z
reviewed
Aug 20, 2022
Codecov Report
@@ Coverage Diff @@
## develop #469 +/- ##
===========================================
- Coverage 37.26% 37.20% -0.06%
===========================================
Files 56 56
Lines 3805 3811 +6
===========================================
Hits 1418 1418
- Misses 2224 2230 +6
Partials 163 163
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mark4z
approved these changes
Aug 27, 2022
PhilYue
reviewed
Aug 28, 2022
PhilYue
reviewed
Aug 28, 2022
| New: func() interface{} { | ||
| pwd, _ := os.Getwd() | ||
| instance := wasmer.NewWasmerInstanceFromFile(filepath.Join(pwd, cfg.Path)) | ||
| proxywasm.RegisterImports(instance) |
There was a problem hiding this comment.
instance 做非空判断，或者提前判断 path 下 wasm 文件是否存在，给出友好 log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Pixiu supports the WASM plugin mechanism, and provides a simple implementation of WASM plugins.
Which issue(s) this PR fixes:
Fixes #432
Special notes for your reviewer: