Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ftr: allow user set custom params to register to registry #117

Merged
merged 9 commits into from
Jul 3, 2019

Conversation

hxmhlt
Copy link
Contributor

@hxmhlt hxmhlt commented Jul 2, 2019

What this PR does:

New Ftr: allow user set custom params to register to registry
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

User can set references & services params in consumer.yml & provider.yml

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #117 into develop will increase coverage by 1.36%.
The diff coverage is 58.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
+ Coverage    67.21%   68.57%   +1.36%     
===========================================
  Files           69       69              
  Lines         4346     4363      +17     
===========================================
+ Hits          2921     2992      +71     
+ Misses        1123     1072      -51     
+ Partials       302      299       -3
Impacted Files Coverage Δ
config/registry_config.go 91.17% <ø> (ø) ⬆️
remoting/zookeeper/listener.go 45.94% <0%> (+2.16%) ⬆️
config/service_config.go 66.66% <0%> (-1.83%) ⬇️
config/reference_config.go 92% <100%> (+0.21%) ⬆️
common/config/environment.go 80.55% <28.57%> (-10.07%) ⬇️
config/base_config.go 63.51% <73.68%> (-0.52%) ⬇️
remoting/zookeeper/client.go 64.16% <0%> (+4.62%) ⬆️
protocol/dubbo/pool.go 62.01% <0%> (+5.02%) ⬆️
protocol/dubbo/readwriter.go 72.97% <0%> (+5.4%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd297e8...cc1f089. Read the comment docs.

@wongoo
Copy link
Contributor

wongoo commented Jul 3, 2019

LGTM

@AlexStocks AlexStocks merged commit d59c087 into apache:develop Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants