Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add v3router to dubbogo #1187

Merged
merged 6 commits into from
May 8, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LaurenceLiZhixin LaurenceLiZhixin changed the base branch from master to 3.0 May 4, 2021 04:45
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #1187 (fd5aa59) into 3.0 (968650f) will decrease coverage by 3.59%.
The diff coverage is 51.58%.

❗ Current head fd5aa59 differs from pull request most recent head c603af6. Consider uploading reports for the commit c603af6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1187      +/-   ##
==========================================
- Coverage   59.53%   55.94%   -3.60%     
==========================================
  Files         259      269      +10     
  Lines       12737    12818      +81     
==========================================
- Hits         7583     7171     -412     
- Misses       4199     4753     +554     
+ Partials      955      894      -61     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 254 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3180469...c603af6. Read the comment docs.

@wongoo
Copy link
Contributor

wongoo commented May 7, 2021

judger的设计直接依赖于config配置,在运行时依据配置进行判断,都是重复性的工作,看这部分是不是可以优化。每个judger只需依赖自己需要的信息即可。

@LaurenceLiZhixin
Copy link
Contributor Author

judger的设计直接依赖于config配置,在运行时依据配置进行判断,都是重复性的工作,看这部分是不是可以优化。每个judger只需依赖自己需要的信息即可。

目前来说每个judger是只依赖自己的需要的信息。望哥的意思是不直接依赖于配置?让每个judger自己保存关心的字段么?我觉得可以之后优化一下。

@wongoo
Copy link
Contributor

wongoo commented May 8, 2021

judger的设计直接依赖于config配置,在运行时依据配置进行判断,都是重复性的工作,看这部分是不是可以优化。每个judger只需依赖自己需要的信息即可。

目前来说每个judger是只依赖自己的需要的信息。望哥的意思是不直接依赖于配置?让每个judger自己保存关心的字段么?我觉得可以之后优化一下。

是的,可以后续优化

@AlexStocks AlexStocks merged commit 76d056e into apache:3.0 May 8, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants