Fix:url.Values is not safe map #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap read and map write error
Codecov Report
@@ Coverage Diff @@
## develop #172 +/- ##
==========================================
+ Coverage 66.57% 67.9% +1.32%
==========================================
Files 90 94 +4
Lines 5544 5851 +307
==========================================
+ Hits 3691 3973 +282
- Misses 1461 1466 +5
- Partials 392 412 +20
Continue to review full report at Codecov.
|
|
Does this fix #146? |
AlexStocks
reviewed
Aug 27, 2019
common/url.go
Outdated
| } | ||
|
|
||
| func (c URL) GetParam(s string, d string) string { | ||
| var r string | ||
| c.paramsLock.RLock() | ||
| if r = c.Params.Get(s); r == "" { |
| Port string | ||
| Params url.Values | ||
| //url.Values is not safe map, add to avoid concurrent map read and map write error | ||
| paramsLock sync.RWMutex |
There was a problem hiding this comment.
pls place the paramsLock before Params
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Url.Values is not safe map, so add the lock to avoid concurrent map read and map write error
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: