Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #207: common/utils/net_test.go:25 cannot pass #209

Merged
merged 6 commits into from
Sep 19, 2019
Merged

fix issue #207: common/utils/net_test.go:25 cannot pass #209

merged 6 commits into from
Sep 19, 2019

Conversation

beiwei30
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #207

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


common/utils/net.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #209 into develop will increase coverage by <.01%.
The diff coverage is 63.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
+ Coverage    65.28%   65.28%   +<.01%     
===========================================
  Files           96       96              
  Lines         6444     6462      +18     
===========================================
+ Hits          4207     4219      +12     
- Misses        1798     1801       +3     
- Partials       439      442       +3
Impacted Files Coverage Δ
common/utils/net.go 62% <63.88%> (-9.88%) ⬇️
remoting/zookeeper/client.go 64.45% <0%> (+0.57%) ⬆️
remoting/zookeeper/listener.go 47.93% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a977cc9...42715c6. Read the comment docs.

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/utils/net.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 4e5152e into apache:develop Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants