-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: TpsLimitSupport #237
Ftr: TpsLimitSupport #237
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #237 +/- ##
==========================================
+ Coverage 65.36% 65.4% +0.03%
==========================================
Files 95 104 +9
Lines 6563 6744 +181
==========================================
+ Hits 4290 4411 +121
- Misses 1832 1891 +59
- Partials 441 442 +1
Continue to review full report at Codecov.
|
filter/impl/tps_limit_thread_safe_fix_window_strategy_impl_test.go
Outdated
Show resolved
Hide resolved
has you checked it again by your examples, when modified? |
I've tested end to end. |
done, and had tested it again. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you have considered impl the limiter by channel? |
What this PR does:
Add TpsLimitFilter. The TpsLimitFilter is one of the default filters. However, if the tps.limiter is nil or the tps.limit.rate < 0, the TpsLimitFilter will do nothing.
Which issue(s) this PR fixes:
Ftr: TPSLimitFilter Support
Fixes #220
Special notes for your reviewer:
Does this PR introduce a user-facing change?: