Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr: config center apollo #250

Merged
merged 30 commits into from
Nov 15, 2019
Merged

Ftr: config center apollo #250

merged 30 commits into from
Nov 15, 2019

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Nov 4, 2019

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@zouyx zouyx changed the base branch from master to develop November 4, 2019 11:06
@codecov-io
Copy link

codecov-io commented Nov 5, 2019 •
edited
Loading

Codecov Report

Merging #250 into develop will increase coverage by 1.2%.
The diff coverage is 83.03%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #250     +/-   ##
=========================================
+ Coverage       65%   66.2%   +1.2%     
=========================================
  Files          105     108      +3     
  Lines         6792    6903    +111     
=========================================
+ Hits          4415    4570    +155     
+ Misses        1932    1881     -51     
- Partials       445     452      +7
Impacted Files Coverage Δ
config_center/zookeeper/factory.go 12.5% <0%> (+3.4%) ⬆️
config_center/apollo/listener.go 100% <100%> (ø)
config/config_center_config.go 69.23% <100%> (+26.37%) ⬆️
config/base_config.go 64.61% <100%> (ø) ⬆️
config_center/apollo/factory.go 20% <20%> (ø)
config_center/apollo/impl.go 87.01% <87.01%> (ø)
registry/zookeeper/registry.go 58.77% <0%> (+0.76%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836bdd0...5757daa. Read the comment docs.

@zouyx
Copy link
Member Author

zouyx commented Nov 5, 2019

Ref : #76

AlexStocks
AlexStocks reviewed Nov 6, 2019
View reviewed changes
config/config_center_config.go Outdated Show resolved Hide resolved
config_center/apollo/impl.go Outdated Show resolved Hide resolved
config_center/apollo/impl.go Show resolved Hide resolved
config_center/apollo/impl_test.go Show resolved Hide resolved
config_center/apollo/impl_test.go Outdated Show resolved Hide resolved
config_center/apollo/impl_test.go Outdated Show resolved Hide resolved
config_center/apollo/listener.go Show resolved Hide resolved
hxmhlt
hxmhlt reviewed Nov 6, 2019
View reviewed changes
config/config_center_config.go Show resolved Hide resolved
config_center/apollo/impl.go Outdated Show resolved Hide resolved
config/config_center_config.go Show resolved Hide resolved
config_center/apollo/impl.go Show resolved Hide resolved
@zouyx zouyx changed the title Add: config center apollo Frt: config center apollo Nov 7, 2019
@zouyx zouyx changed the title Frt: config center apollo Ftr: config center apollo Nov 7, 2019
fangyincheng
fangyincheng reviewed Nov 7, 2019
View reviewed changes
config/base_config_test.go Outdated Show resolved Hide resolved
config_center/apollo/factory.go Show resolved Hide resolved
config_center/apollo/impl.go Outdated Show resolved Hide resolved
AlexStocks
AlexStocks reviewed Nov 8, 2019
View reviewed changes
config_center/apollo/factory.go Outdated Show resolved Hide resolved
config_center/apollo/factory.go Outdated Show resolved Hide resolved
config_center/apollo/listener.go Show resolved Hide resolved
hxmhlt
hxmhlt reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@hxmhlt hxmhlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you can write an example about enabling apollo config center in https://github.com/dubbogo/dubbogo-samples for your code logic validation.

config/config_center_config.go Show resolved Hide resolved
@zouyx
Copy link
Member Author

zouyx commented Nov 8, 2019

I think maybe you can write an example about enabling apollo config center in https://github.com/dubbogo/dubbogo-samples for your code logic validation.

ok, ASAP

fangyincheng
fangyincheng reviewed Nov 14, 2019
View reviewed changes
config_center/zookeeper/factory.go Show resolved Hide resolved
config/config_center_config.go Show resolved Hide resolved
config_center/apollo/factory.go Show resolved Hide resolved
fangyincheng
fangyincheng approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hxmhlt
hxmhlt approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit d82e97f into apache:develop Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks left review comments

@fangyincheng fangyincheng fangyincheng approved these changes

@hxmhlt hxmhlt hxmhlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zouyx @codecov-io @AlexStocks @hxmhlt @fangyincheng @apollo-go @xujianhai666