feat(grpc): 支持client grpc 调用 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: imxyb <xyb4638@gmail.com>
Codecov Report
@@ Coverage Diff @@
## feature/grpc #275 +/- ##
================================================
- Coverage 66.59% 66.16% -0.43%
================================================
Files 112 118 +6
Lines 7175 7380 +205
================================================
+ Hits 4778 4883 +105
- Misses 1932 2017 +85
- Partials 465 480 +15
Continue to review full report at Codecov.
|
xujianhai666
commented
Dec 8, 2019
feat(dubbo/invoker): 修改dubbo 关闭的方式
Add: Split config center GetConfig method
fix(common): use new uuid method
Develop generic code fix
AlexStocks
reviewed
Jan 4, 2020
| @@ -449,6 +449,7 @@ github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81P | |||
| github.com/tebeka/strftime v0.1.3 h1:5HQXOqWKYRFfNyBMNVc9z5+QzuBtIXy03psIhtdJYto= | |||
| github.com/tebeka/strftime v0.1.3/go.mod h1:7wJm3dZlpr4l/oVK0t1HYIc4rMzQ2XJlOMIUJUJH6XQ= | |||
| github.com/tent/http-link-go v0.0.0-20130702225549-ac974c61c2f9/go.mod h1:RHkNRtSLfOK7qBTHaeSX1D6BNpI3qw7NTxsmNr4RvN8= | |||
| github.com/tevid/gohamcrest v1.1.1 h1:ou+xSqlIw1xfGTg1uq1nif/htZ2S3EzRqLm2BP+tYU0= | |||
There was a problem hiding this comment.
u used so much unqualified packages.
There was a problem hiding this comment.
it is from agollo：
-> % go mod why github.com/tevid/gohamcrest
github.com/tevid/gohamcrest
github.com/apache/dubbo-go/config_center/apollo
github.com/zouyx/agollo
github.com/zouyx/agollo.test
github.com/tevid/gohamcrest
Imp: receive heartbeat from server
xujianhai666
force-pushed
the
feature/grpc-client
branch
from
c976a75 to
ebcb9f6
Compare
flycash
reviewed
Jan 8, 2020
| } | ||
|
|
||
| gp.serverLock.Lock() | ||
| _, ok = gp.serverMap[url.Location] |
There was a problem hiding this comment.
How about:
gp.serverLock.Lock()
_, ok = gp.serverMap[url.Location]
if !ok {
srv := NewServer()
gp.serverMap[url.Location] = srv
gp.serverLock.Unlock()
srv.Start(url)
return
}
gp.serverLock.Unlock()I think we can release the lock before invoking srv.Start(url)
flycash
approved these changes
Jan 8, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.