Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Generic Implement #291

Merged
merged 15 commits into from
Jan 7, 2020
Merged

Conversation

Patrick0308
Copy link
Contributor

What this PR does:
Ftr: add Generic Implement

Which issue(s) this PR fixes
Fixes #290

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@1c5cca4). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #291   +/-   ##
==========================================
  Coverage           ?   66.56%           
==========================================
  Files              ?      113           
  Lines              ?     7230           
  Branches           ?        0           
==========================================
  Hits               ?     4813           
  Misses             ?     1946           
  Partials           ?      471
Impacted Files Coverage Δ
filter/tps/tps_limiter_method_service.go 80% <ø> (ø)
filter/tps/tps_limit_fix_window_strategy.go 100% <ø> (ø)
filter/tps/tps_limit_sliding_window_strategy.go 100% <ø> (ø)
...r/tps/tps_limit_thread_safe_fix_window_strategy.go 100% <ø> (ø)
filter/filter/generic_filter.go 67.69% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5cca4...bd7989a. Read the comment docs.

filter/impl/generic_service_filter.go Outdated Show resolved Hide resolved
filter/impl/generic_service_filter.go Outdated Show resolved Hide resolved
filter/impl/generic_service_filter_test.go Outdated Show resolved Hide resolved
@Patrick0308
Copy link
Contributor Author

@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

@AlexStocks
Copy link
Contributor

@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

pls give some adives @fangyincheng @hxmhlt @pantianying

@fangyincheng
Copy link
Contributor

you need a switch to control whether generic_service should be working, instead of default

@Patrick0308
Copy link
Contributor Author

@fangyincheng In java sdk, generic filter is default filter. In go, do we need to control it be working?

@fangyincheng
Copy link
Contributor

@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

dubbo-go support lowercase method to provide a service.

image

@fangyincheng
Copy link
Contributor

@fangyincheng In java sdk, generic filter is default filter. In go, do we need to control it be working?

ok

filter/impl/generic_service_filter.go Outdated Show resolved Hide resolved
filter/impl/generic_service_filter.go Outdated Show resolved Hide resolved
@Patrick0308
Copy link
Contributor Author

@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

dubbo-go support lowercase method to provide a service.

image

I see.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng
Copy link
Contributor

Has it been tested with java Dubbo?

@Patrick0308
Copy link
Contributor Author

@fangyincheng yeah, I tested

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 8394520 into apache:develop Jan 7, 2020
@Patrick0308 Patrick0308 deleted the generic-service branch March 6, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants