Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Prometheus Support —— Summary & Histogram #342

Merged
merged 16 commits into from
Feb 5, 2020

Conversation

flycash
Copy link
Member

@flycash flycash commented Jan 26, 2020

What this PR does:

Creating a MetricsFilter to collect the invocation's information.

Now we support the summary and histogram

image

image

Now we support Prometheus!!!

@flycash flycash changed the title Feature/prometheus Ftr: Prometheus Support —— Summary Jan 26, 2020
@codecov-io
Copy link

codecov-io commented Jan 26, 2020

Codecov Report

Merging #342 into develop will decrease coverage by 0.21%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
- Coverage    66.25%   66.04%   -0.22%     
===========================================
  Files          139      139              
  Lines         7830     7845      +15     
===========================================
- Hits          5188     5181       -7     
- Misses        2147     2164      +17     
- Partials       495      500       +5
Impacted Files Coverage Δ
config_center/zookeeper/impl.go 40% <ø> (ø) ⬆️
registry/zookeeper/registry.go 55.55% <ø> (ø) ⬆️
remoting/zookeeper/listener.go 52.02% <20%> (-1.24%) ⬇️
remoting/zookeeper/client.go 68.06% <80%> (+0.14%) ⬆️
protocol/dubbo/codec.go 70.27% <0%> (-5.41%) ⬇️
protocol/dubbo/listener.go 57.83% <0%> (-5.41%) ⬇️
protocol/dubbo/pool.go 77.67% <0%> (-4.66%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0%> (-2.44%) ⬇️
registry/etcdv3/registry.go 51.51% <0%> (+1.01%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 72.46% <0%> (+10.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229e027...31ca039. Read the comment docs.

config/metric_config.go Outdated Show resolved Hide resolved
config/metric_config.go Outdated Show resolved Hide resolved
@flycash flycash changed the title Ftr: Prometheus Support —— Summary Ftr: Prometheus Support —— Summary & Histogram Jan 27, 2020
common/extension/metrics.go Show resolved Hide resolved
config/config_loader.go Show resolved Hide resolved
config/metric_config.go Outdated Show resolved Hide resolved
filter/filter_impl/metrics_filter.go Show resolved Hide resolved
Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit 0074a01 into apache:develop Feb 5, 2020
@flycash flycash mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants