Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add jackson serialization extension #231

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Nov 3, 2023

What is the purpose of the change

Add jackson serialization support

Brief changelog

Add jackson serialization support

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@aofall
Copy link
Contributor Author

aofall commented Nov 4, 2023

@AlbumenJ PTAL

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #231 (1f6f949) into master (b7d4fd4) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
- Coverage     33.98%   33.96%   -0.02%     
+ Complexity      508      506       -2     
============================================
  Files           156      156              
  Lines          5326     5326              
  Branches        662      662              
============================================
- Hits           1810     1809       -1     
- Misses         3315     3316       +1     
  Partials        201      201              

see 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@AlbumenJ AlbumenJ merged commit 180f782 into apache:master Nov 6, 2023
14 checks passed
@aofall aofall deleted the jackson-path branch November 9, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants