Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE dubbo#11900] part4 init dubbo-wasm-registry-api module #285

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

loongs-zhang
Copy link
Member

@loongs-zhang loongs-zhang commented Feb 4, 2024

What is the purpose of the change

This PR also refactor test, now the tests of rust part are all in dubbo-wasm/dubbo-wasm-test module.

see apache/dubbo#11900

Verifying this change

see dubbo-wasm/dubbo-wasm-registry-api/src/test

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efd18a6) 25.17% compared to head (92c9d2f) 26.08%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
+ Coverage     25.17%   26.08%   +0.90%     
- Complexity     1007     1057      +50     
============================================
  Files           285      292       +7     
  Lines         13154    13401     +247     
  Branches       1703     1702       -1     
============================================
+ Hits           3312     3496     +184     
- Misses         9504     9568      +64     
+ Partials        338      337       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loongs-zhang loongs-zhang reopened this Feb 4, 2024
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit db631fc into apache:master Feb 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants