-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jetcd vertsion from 0.5.7 to 0.7.7 #398
Conversation
why rename etcd3?His name should not be rename easily |
You can read I try to use extend class to compatible the old version now, waiting for CI check pass. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #398 +/- ##
======================================
Coverage ? 31.35%
Complexity ? 459
======================================
Files ? 150
Lines ? 5205
Branches ? 654
======================================
Hits ? 1632
Misses ? 3400
Partials ? 173 ☔ View full report in Codecov by Sentry. |
* update jetcd version * rename the dubbo-registry-etcd extension name from etcd3 to etcd * fix unit test failed * compatible old version * add ASF header
* Bump jetcd vertsion from 0.5.7 to 0.7.7 (#398) * update jetcd version * rename the dubbo-registry-etcd extension name from etcd3 to etcd * fix unit test failed * compatible old version * add ASF header * ci: Upload coverage to Codecov after unit test
What is the purpose of the change
etcd://127.0.0.1:2379
, the registry address is inconsistent with the other two.Brief changelog
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sureunit-test and integration-test pass.
the Software Donation Guide.