Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jetcd vertsion from 0.5.7 to 0.7.7 #398

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Jun 6, 2024

What is the purpose of the change

  1. Bump jetcd vertsion from 0.5.7 to 0.7.7
  2. Rename the dubbo-registry-etcd extension name from etcd3 to etcd, because the metadata-etcd and configcenter-etcd use the etcd://127.0.0.1:2379 , the registry address is inconsistent with the other two.

Brief changelog

  1. Bump jetcd vertsion from 0.5.7 to 0.7.7
  2. Rename the dubbo-registry-etcd extension name from etcd3 to etcd

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@wcy666103
Copy link
Contributor

why rename etcd3?His name should not be rename easily

@aofall
Copy link
Contributor Author

aofall commented Jun 7, 2024

why rename etcd3?His name should not be rename easily

You can read What is the purpose of the change again :)

I try to use extend class to compatible the old version now, waiting for CI check pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.0@6b534a8). Learn more about missing BASE report.

Files Patch % Lines
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0.00% 3 Missing ⚠️
...o/registry/etcd/EtcdCompatibleRegistryFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             3.0     #398   +/-   ##
======================================
  Coverage       ?   31.35%           
  Complexity     ?      459           
======================================
  Files          ?      150           
  Lines          ?     5205           
  Branches       ?      654           
======================================
  Hits           ?     1632           
  Misses         ?     3400           
  Partials       ?      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songxiaosheng songxiaosheng merged commit c6dc17d into apache:3.0 Jun 11, 2024
16 checks passed
aofall added a commit to aofall/dubbo-spi-extensions that referenced this pull request Jun 14, 2024
* update jetcd version

* rename the dubbo-registry-etcd extension name from etcd3 to etcd

* fix unit test failed

* compatible old version

* add ASF header
songxiaosheng pushed a commit that referenced this pull request Jun 15, 2024
* Bump jetcd vertsion from 0.5.7 to 0.7.7 (#398)

* update jetcd version

* rename the dubbo-registry-etcd extension name from etcd3 to etcd

* fix unit test failed

* compatible old version

* add ASF header

* ci: Upload coverage to Codecov after unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants