#4685 修改代码if判断false问题 if (hasException == false)修改成if (!hasException) (…

…#4695)
apache · Jul 30, 2019 · 25ec31e · 25ec31e
1 parent 5d299af
commit 25ec31e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/dubbo-compatible/src/test/java/org/apache/dubbo/filter/LegacyInvoker.java b/dubbo-compatible/src/test/java/org/apache/dubbo/filter/LegacyInvoker.java
@@ -59,7 +59,7 @@ public boolean isAvailable() {
 
     public Result invoke(Invocation invocation) throws RpcException {
         AppResponse result = new AppResponse();
-        if (hasException == false) {
+        if (!hasException) {
             result.setValue("alibaba");
         } else {
             result.setException(new RuntimeException("mocked exception"));

diff --git a/...ubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/PerformanceClientFixedTest.java b/...ubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/PerformanceClientFixedTest.java
@@ -80,7 +80,7 @@ public void testClient() throws Exception {
             } catch (Throwable t) {
                 t.printStackTrace();
             } finally {
-                if (client != null && client.isConnected() == false) {
+                if (client != null && !client.isConnected()) {
                     f++;
                     System.out.println("open client failed, try again " + f);
                     client.close();

diff --git a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/support/BlockMyInvoker.java b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/support/BlockMyInvoker.java
@@ -40,7 +40,7 @@ public BlockMyInvoker(URL url, boolean hasException, long blockTime) {
     @Override
     public Result invoke(Invocation invocation) throws RpcException {
         AppResponse result = new AppResponse();
-        if (hasException == false) {
+        if (!hasException) {
             try {
                 Thread.sleep(blockTime);
             } catch (InterruptedException e) {

diff --git a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/support/MyInvoker.java b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/support/MyInvoker.java
@@ -60,7 +60,7 @@ public boolean isAvailable() {
 
     public Result invoke(Invocation invocation) throws RpcException {
         AppResponse result = new AppResponse();
-        if (hasException == false) {
+        if (!hasException) {
             result.setValue("alibaba");
         } else {
             result.setException(new RuntimeException("mocked exception"));