Add 'forks' config into xml config (#2568)

* Add forks into xml config. * Add forks into xml config. * Add forks into xml config.
apache · Nov 6, 2018 · 56b2193 · 56b2193
1 parent aed0102
commit 56b2193
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 0 deletions.
diff --git a/...o-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java b/...o-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
@@ -64,6 +64,19 @@ public abstract class AbstractMethodConfig extends AbstractConfig {
     // customized parameters
     protected Map<String, String> parameters;
 
+    /**
+     * forks for forking cluster
+     */
+    protected Integer forks;
+
+    public Integer getForks() {
+        return forks;
+    }
+
+    public void setForks(Integer forks) {
+        this.forks = forks;
+    }
+
     public Integer getTimeout() {
         return timeout;
     }

diff --git a/...nfig/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java b/...nfig/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractMethodConfigTest.java
@@ -35,6 +35,13 @@ public void testTimeout() throws Exception {
         assertThat(methodConfig.getTimeout(), equalTo(10));
     }
 
+    @Test
+    public void testForks() throws Exception {
+        MethodConfig methodConfig = new MethodConfig();
+        methodConfig.setForks(10);
+        assertThat(methodConfig.getForks(), equalTo(10));
+    }
+
     @Test
     public void testRetries() throws Exception {
         MethodConfig methodConfig = new MethodConfig();

diff --git a/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/compat/dubbo.xsd b/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/compat/dubbo.xsd
@@ -101,6 +101,11 @@
                         <xsd:documentation><![CDATA[ Use cluster strategy. ]]></xsd:documentation>
                     </xsd:annotation>
                 </xsd:attribute>
+                <xsd:attribute name="forks" type="xsd:string">
+                    <xsd:annotation>
+                        <xsd:documentation><![CDATA[ ForkingCluster forks. ]]></xsd:documentation>
+                    </xsd:annotation>
+                </xsd:attribute>
                 <xsd:attribute name="filter" type="xsd:string">
                     <xsd:annotation>
                         <xsd:documentation><![CDATA[ The filter. ]]></xsd:documentation>
@@ -492,6 +497,11 @@
                 <xsd:documentation><![CDATA[ The registry cluster type. ]]></xsd:documentation>
             </xsd:annotation>
         </xsd:attribute>
+        <xsd:attribute name="forks" type="xsd:string">
+            <xsd:annotation>
+                <xsd:documentation><![CDATA[ ForkingCluster forks. ]]></xsd:documentation>
+            </xsd:annotation>
+        </xsd:attribute>
         <xsd:attribute name="group" type="xsd:string">
             <xsd:annotation>
                 <xsd:documentation><![CDATA[ The registry group. ]]></xsd:documentation>

diff --git a/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd b/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd
@@ -101,6 +101,11 @@
                         <xsd:documentation><![CDATA[ Use cluster strategy. ]]></xsd:documentation>
                     </xsd:annotation>
                 </xsd:attribute>
+                <xsd:attribute name="forks" type="xsd:string">
+                    <xsd:annotation>
+                        <xsd:documentation><![CDATA[ ForkingCluster forks. ]]></xsd:documentation>
+                    </xsd:annotation>
+                </xsd:attribute>
                 <xsd:attribute name="filter" type="xsd:string">
                     <xsd:annotation>
                         <xsd:documentation><![CDATA[ The filter. ]]></xsd:documentation>
@@ -486,6 +491,11 @@
                 <xsd:documentation><![CDATA[ The registry cluster type. ]]></xsd:documentation>
             </xsd:annotation>
         </xsd:attribute>
+        <xsd:attribute name="forks" type="xsd:string">
+            <xsd:annotation>
+                <xsd:documentation><![CDATA[ ForkingCluster forks. ]]></xsd:documentation>
+            </xsd:annotation>
+        </xsd:attribute>
         <xsd:attribute name="group" type="xsd:string">
             <xsd:annotation>
                 <xsd:documentation><![CDATA[ The registry group. ]]></xsd:documentation>

diff --git a/...o-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ConfigTest.java b/...o-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ConfigTest.java
@@ -147,6 +147,20 @@ public void testToString() {
         assertTrue(str.endsWith(" />"));
     }
 
+    @Test
+    public void testForks() {
+        ReferenceConfig<DemoService> reference = new ReferenceConfig<DemoService>();
+        reference.setApplication(new ApplicationConfig("consumer"));
+        reference.setRegistry(new RegistryConfig(RegistryConfig.NO_AVAILABLE));
+        reference.setInterface(DemoService.class);
+        reference.setUrl("dubbo://127.0.0.1:20881");
+
+        int forks = 10;
+        reference.setForks(forks);
+        String str = reference.toString();
+        assertTrue(str.contains("forks=\"" + forks + "\""));
+    }
+
     @Test
     public void testMultiProtocol() {
         ClassPathXmlApplicationContext ctx = new ClassPathXmlApplicationContext(ConfigTest.class.getPackage().getName().replace('.', '/') + "/multi-protocol.xml");