Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-compiler: manifest references non-existing main class #14818

Closed
4 tasks done
JanSoundhouse opened this issue Oct 23, 2024 · 0 comments · Fixed by #14815
Closed
4 tasks done

dubbo-compiler: manifest references non-existing main class #14818

JanSoundhouse opened this issue Oct 23, 2024 · 0 comments · Fixed by #14815
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@JanSoundhouse
Copy link
Contributor

JanSoundhouse commented Oct 23, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Like the title says, the current manifest for the dubbo-compiler points to a not existing main class.
DubboGrpcGenerator class was removed with commit af0f45f "feat:dubbo-compiler remove grpc and grpc/reactive package" and replaced by Dubbo3TripleGenerator. The mainfest was not changed accordingly.

Steps to reproduce this issue

Just call java -jar dubbo-compiler-3.3.1.jar and observe the ClassNotFoundException for DubboGrpcGenerator.

What you expected to happen

Not throwing a ClassNotFoundException

Anything else

PR #14815 solves this

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant