Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-compiler: pom.xml: set manifest main class to Dubbo3TripleGenerator #14815

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

JanSoundhouse
Copy link
Contributor

@JanSoundhouse JanSoundhouse commented Oct 22, 2024

The DubboGrpcGenerator class was removed with commit af0f45f "feat:dubbo-compiler remove grpc and grpc/reactive package"

fixes #14818

…ator

The DubboGrpcGenerator class was removed with commit af0f45f "feat:dubbo-compiler remove grpc and grpc/reactive package"
@JanSoundhouse
Copy link
Contributor Author

@AlbumenJ:
Can you start the "Build and Test For PR" again, please? I don't think the little fix could cause the building of the ubuntu test image to fail.

Also: do you need an issue for this fix? I would have done in the first place but its such a minor change.

Regards
jan

@AlbumenJ AlbumenJ merged commit 40b9bf2 into apache:3.3 Oct 25, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo-compiler: manifest references non-existing main class
2 participants