-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dubbo 2.6.x cannot found correct method with telnet command #4565
Milestone
Comments
@qixiaobo Can you fire a pull request? I find it is very severe problem when there are override methods. |
qixiaobo
added a commit
to qixiaobo/dubbo
that referenced
this issue
Jul 20, 2019
@qixiaobo sorry about it, I think I should have time to review it tomorrow. |
Never mind |
Hope you may have time |
chickenlj
pushed a commit
that referenced
this issue
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
When we use complex arguments, in telnet mode , we need use jsonArray to parse.
But in our code ,someone try to resolve an overwrite problem ,so make an issue #257
then @beiwei30 try to fix this issue use this code below 27917f2
The code will make the default method not take effect.
The code before like this
We can have a default method with the the methodName and the same length arguments.
But after the code change , it must provides the correct arguments type. We should know
json parse cannot give the corrent type. It maybe JsonObject or even HashMap.
So someone points out this problem #2766.
In my opinion ,we should not define the same name method. Such as retry or timeout , these configs may just take effect in method or service or provider .In these cases ,methodName can stands for method. That is to say ,a lot of configs just consider the method name .
In dubbo 2.7.x, for this issue ,dubbo provides a new telnet command called select.
So ,We should consider which is better.
The text was updated successfully, but these errors were encountered: