-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-1201] Fix condition router #1204
Conversation
|
Codecov Report
@@ Coverage Diff @@
## 2.5.x #1204 +/- ##
==========================================
+ Coverage 27.55% 27.55% +<.01%
==========================================
Files 789 789
Lines 41565 41567 +2
Branches 8476 8477 +1
==========================================
+ Hits 11454 11455 +1
- Misses 28061 28067 +6
+ Partials 2050 2045 -5
Continue to review full report at Codecov.
|
I think this change is quite reasonable. Anyone has other opinion? |
What is the purpose of the change
Fix condition router to process default.xxx vaule in url.
Brief changelog
Modify test case of conditon router, add default.xxx=yyy parameter in url, add route codition xxx=yyy.
Modify condition router. Try to get default.xxx value when xxx is null.
Verifying this change
Start two providers, one with configuration <dubbo:provider xxx="yyy" />.
Add condition router "=> xxx=yyy".
Start one consumer, all request should send to provide whit configuration <dubbo:provider xxx="yyy" />.