Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-1201] Fix condition router #1204

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Conversation

haodut
Copy link
Contributor

@haodut haodut commented Jan 12, 2018

What is the purpose of the change

Fix condition router to process default.xxx vaule in url.

Brief changelog

Modify test case of conditon router, add default.xxx=yyy parameter in url, add route codition xxx=yyy.
Modify condition router. Try to get default.xxx value when xxx is null.

Verifying this change

Start two providers, one with configuration <dubbo:provider xxx="yyy" />.
Add condition router "=> xxx=yyy".
Start one consumer, all request should send to provide whit configuration <dubbo:provider xxx="yyy" />.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2018

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #1204 into 2.5.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.5.x    #1204      +/-   ##
==========================================
+ Coverage   27.55%   27.55%   +<.01%     
==========================================
  Files         789      789              
  Lines       41565    41567       +2     
  Branches     8476     8477       +1     
==========================================
+ Hits        11454    11455       +1     
- Misses      28061    28067       +6     
+ Partials     2050     2045       -5
Impacted Files Coverage Δ
.../rpc/cluster/router/condition/ConditionRouter.java 71.11% <100%> (+1.93%) ⬆️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-11.12%) ⬇️
.../java/com/alibaba/dubbo/common/utils/NetUtils.java 8.95% <0%> (-6.72%) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) ⬇️
...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java 64.32% <0%> (-1.01%) ⬇️
...aba/dubbo/monitor/simple/SimpleMonitorService.java 52.34% <0%> (-0.86%) ⬇️
...mmon/serialize/support/dubbo/GenericDataInput.java 59.45% <0%> (+0.77%) ⬆️
...mon/serialize/support/dubbo/GenericDataOutput.java 66.66% <0%> (+1.4%) ⬆️
...baba/dubbo/remoting/transport/mina/MinaClient.java 59.42% <0%> (+1.44%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b309f79...fea1bf9. Read the comment docs.

@chickenlj
Copy link
Contributor

I think this change is quite reasonable. Anyone has other opinion?

@chickenlj chickenlj merged commit 5af1878 into apache:2.5.x Jan 17, 2018
@chickenlj chickenlj modified the milestones: 2.5.9, 2.6.1, 2.5.10 Mar 16, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants