2.5.9 Annotation Enhancement and Bugfix #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix alibaba/dubbo apache#1120
To resolve alibaba/dubbo apache#1125
To resolve alibaba/dubbo apache#1125
multiple Config Bean To resolve alibaba/dubbo apache#1141
Codecov Report
@@ Coverage Diff @@
## 2.5.x #1205 +/- ##
==========================================
- Coverage 27.55% 27.51% -0.05%
==========================================
Files 789 790 +1
Lines 41565 41587 +22
Branches 8476 8480 +4
==========================================
- Hits 11454 11441 -13
- Misses 28061 28109 +48
+ Partials 2050 2037 -13
Continue to review full report at Codecov.
|
|
@mercyblitz Would you please revert the dubbo version? There are too many irrelevant changes that bothers when reviewing. |
|
@chickenlj Done |
rolandhe
pushed a commit
to rolandhe/dubbo
that referenced
this pull request
Sep 9, 2019
* Fixed apache#1116 apache#1120 apache#1121 apache#1122 apache#1141 apache#1125 * DubboConfigConfiguration's Single and Multiple to be public classes * @DubboComponentScan is compatible with Spring @service completely * @service and @reference issues on <dubbo:annotation> * To fix an issue on <dubbo:annotation> when id attribute is absent * To change the prefixes of properties when @EnableDubboConfig binds multiple Config Bean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Annotation Enhancement and bugfix
Bugfix
@DubboComponentScanis not compatible Spring @service completely @DubboComponentScan is not compatible Spring @Service completely #1120Enhancement
ReferenceBeanshould be exposable for production-ready features ReferenceBean should be exposable for production-ready features #1121DubboConfigConfiguration's Single and Multiple to be public classes DubboConfigConfiguration's Single and Multiple to be public classes #1122Break Change
Verifying this change
Run use-tests