-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate tracing core from boot-start to dubbo deployer #12453
Conversation
92e4f86
to
2384995
Compare
9a93f5b
to
a934230
Compare
Codecov Report
@@ Coverage Diff @@
## 3.2 #12453 +/- ##
=============================================
+ Coverage 68.58% 69.21% +0.62%
+ Complexity 338 2 -336
=============================================
Files 3607 1637 -1970
Lines 168096 67526 -100570
Branches 27971 9907 -18064
=============================================
- Hits 115295 46738 -68557
+ Misses 42759 16266 -26493
+ Partials 10042 4522 -5520 see 2055 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c34f405
to
cc4e9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mode ObservationSenderFilter to dubbo-tracing
dubbo-common/src/main/java/org/apache/dubbo/config/nested/ExporterConfig.java
Outdated
Show resolved
Hide resolved
I've finshed to move ObservationSenderFilter @AlbumenJ |
3339f0b
to
86af14e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f422e8
to
f6b09ba
Compare
|
||
private static boolean isClassPresent(String className) { | ||
return ClassUtils.isPresent(className, DefaultApplicationDeployer.class.getClassLoader()); | ||
DubboObservationRegistry dubboObservationRegistry = new DubboObservationRegistry(applicationModel, configOptional.get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So only when all the above three conditions are matched will we initiate DubboObservationRegistry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, due to the Observation.class was proposed after version 1.10 of micrometer, when users use springroot2.x, it defaults to 1.9.x, which means Observation.class is missing. We have made the corresponding judgment and provided users with debug level log prompts.
As for Option, this is the switch that determines whether Dubbo itself has enabled the Tracing function
Kudos, SonarCloud Quality Gate passed! |
|
…oyer (apache#12453)" This reverts commit ea35f7e.
…oyer (apache#12453)" This reverts commit ea35f7e.
…oyer (apache#12453)" This reverts commit ea35f7e.
What is the purpose of the change
The previous Dubbo Tracing implementation overly relied on the spring boot starter. While providing users with better extensibility, Dubbo Tracing also loses its independence.
So I migrated tracing core from boot-start to dubbo deployer.
Child Task of #12448
Brief changelog
dubbo-tracing
module.Usage
Use SpringBoot Starter
Use Dubbo directly
Verifying this change
Local test result:
dubbo-samples:apache/dubbo-samples#854
TODO
dubbo-samples
.Checklist