-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix log level is null in Slf4j and fix not valid in Log4j2 #12671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AlbumenJ hello,I only fix the slf4j is null but I have not have a good idea on set level |
xixingya
force-pushed
the
feature/230705-fix
branch
from
July 5, 2023 09:21
773419b
to
8a4f00c
Compare
AlbumenJ
approved these changes
Jul 13, 2023
AlbumenJ
requested changes
Jul 13, 2023
dubbo-common/src/main/java/org/apache/dubbo/common/logger/slf4j/Slf4jLoggerAdapter.java
Outdated
Show resolved
Hide resolved
xixingya
commented
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
dubbo-common/src/main/java/org/apache/dubbo/common/logger/slf4j/Slf4jLoggerAdapter.java
Outdated
Show resolved
Hide resolved
AlbumenJ
requested changes
Jul 15, 2023
dubbo-common/src/main/java/org/apache/dubbo/common/logger/slf4j/Slf4jLoggerAdapter.java
Outdated
Show resolved
Hide resolved
@AlbumenJ in this class we can not use dubbo log,may be sout err is a idea |
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
Verifying this change
Checklist
fix 应用初始化启动后,使用telnet查看“日志框架运行时”抛NPE #12650