Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log level is null in Slf4j and fix not valid in Log4j2 #12671

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

xixingya
Copy link
Contributor

@xixingya xixingya commented Jul 5, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
    fix 应用初始化启动后,使用telnet查看“日志框架运行时”抛NPE #12650

@xixingya
Copy link
Contributor Author

xixingya commented Jul 5, 2023

@AlbumenJ hello,I only fix the slf4j is null but I have not have a good idea on set level

@xixingya xixingya requested a review from AlbumenJ July 14, 2023 11:26
Copy link
Contributor Author

@xixingya xixingya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@xixingya xixingya requested a review from AlbumenJ July 17, 2023 03:37
@AlbumenJ
Copy link
Member

image

@xixingya
Copy link
Contributor Author

@AlbumenJ in this class we can not use dubbo log,may be sout err is a idea

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 879fd81 into apache:3.2 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

应用初始化启动后,使用telnet查看“日志框架运行时”抛NPE
2 participants