Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StandardMetadataServiceURLBuilder.java #12684

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

xm101
Copy link
Contributor

@xm101 xm101 commented Jul 6, 2023

修复SIDE_KEY设置被覆盖,导致服务端线程池被覆盖问题
issues:#12683

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

修复SIDE_KEY设置被覆盖问题
@codecov-commenter
Copy link

Codecov Report

Merging #12684 (66e3e75) into 3.1 (9ae97ea) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #12684      +/-   ##
============================================
- Coverage     64.93%   64.93%   -0.01%     
  Complexity       14       14              
============================================
  Files          1433     1433              
  Lines         60130    60130              
  Branches       8857     8857              
============================================
- Hits          39048    39043       -5     
- Misses        16989    16996       +7     
+ Partials       4093     4091       -2     
Impacted Files Coverage Δ
...nt/metadata/StandardMetadataServiceURLBuilder.java 85.45% <100.00%> (ø)

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed in #11936

@xm101
Copy link
Contributor Author

xm101 commented Jul 18, 2023

Already fixed in #11936

应该不是同个问题,11936是本服务的MetadataService线程池覆盖了业务接口线程池,而这个issues的问题是,业务接口线程池被调用的其他服务暴露出来的MetadataService生成的客户端线程池所覆盖

@AlbumenJ
Copy link
Member

Already fixed in #11936

应该不是同个问题,11936是本服务的MetadataService线程池覆盖了业务接口线程池,而这个issues的问题是,业务接口线程池被调用的其他服务暴露出来的MetadataService生成的客户端线程池所覆盖

#11936 这个修复直接把 MetadataService 配置的线程池给删除了

@xm101
Copy link
Contributor Author

xm101 commented Jul 19, 2023

如果我没看错的话,#11936 修复的是暴露本服务MetadataService时的线程池,修改的是ConfigurableMetadataServiceExporter.java,而我发现的是refer,引用其他服务的MetadataService,一个是服务端线程池,一个是客户端线程池,及时这边删除了线程池配置也不合理,这里是为了调用remote获取其他服务的metadata信息,不应该复用服务端线程池,side也不应该为provider,应该是consumer,而源码中也设置了,只是被注册中心的信息覆盖,详见#12683 的代码截图

@xm101
Copy link
Contributor Author

xm101 commented Jul 19, 2023

如果我没看错的话,#11936 修复的是暴露本服务MetadataService时的线程池,修改的是ConfigurableMetadataServiceExporter.java,而我发现的是refer,引用其他服务的MetadataService,一个是服务端线程池,一个是客户端线程池,及时这边删除了线程池配置也不合理,这里是为了调用remote获取其他服务的metadata信息,不应该复用服务端线程池,side也不应该为provider,应该是consumer,而源码中也设置了,只是被注册中心的信息覆盖,详见#12683 的代码截图

@xm101 xm101 closed this Jul 19, 2023
@AlbumenJ AlbumenJ reopened this Jul 29, 2023
@AlbumenJ AlbumenJ merged commit 9ee5bf6 into apache:3.1 Jul 29, 2023
7 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants