🚑 avoid metric bug #12817

songxiaosheng · 2023-07-31T05:33:58Z

What is the purpose of the change

add try catch to avoid metric bug

Brief changelog

Verifying this change

Checklist

Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Add some description to dubbo-website project if you are requesting to add a feature.
GitHub Actions works fine on your own branch.
If this contribution is large, please follow the Software Donation Guide.

AlbumenJ · 2023-07-31T05:49:22Z

...-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/event/MetricsEventBus.java

+        try {
+            tryCallBack.callback();
+        } catch (Throwable e2) {
+            logger.debug("MetricsEventBus tryInvoke error", e2);


Suggested change

logger.debug("MetricsEventBus tryInvoke error", e2);

logger.warn("MetricsEventBus tryInvoke error", e2);

warn with error code

codecov-commenter · 2023-07-31T06:31:09Z

Codecov Report

Merging #12817 (93423c4) into 3.2 (345e58f) will increase coverage by 0.73%.
Report is 33 commits behind head on 3.2.
The diff coverage is n/a.

❗ Current head 93423c4 differs from pull request most recent head 8b22cea. Consider uploading reports for the commit 8b22cea to get more accurate results

@@              Coverage Diff              @@
##                3.2   #12817       +/-   ##
=============================================
+ Coverage     68.66%   69.40%    +0.73%     
+ Complexity      130        2      -128     
=============================================
  Files          3653     1644     -2009     
  Lines        170427    68212   -102215     
  Branches      28018     9973    -18045     
=============================================
- Hits         117031    47343    -69688     
+ Misses        43274    16293    -26981     
+ Partials      10122     4576     -5546

see 2074 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more