Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service offline speedup #12869

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Service offline speedup #12869

merged 2 commits into from
Aug 9, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Aug 9, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

38.5% 38.5% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #12869 (43fe49e) into 3.2 (e7fa74b) will decrease coverage by 0.62%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12869      +/-   ##
============================================
- Coverage     70.05%   69.44%   -0.62%     
+ Complexity      128        2     -126     
============================================
  Files          1874     1647     -227     
  Lines         99066    68364   -30702     
  Branches      17811     9987    -7824     
============================================
- Hits          69403    47475   -21928     
+ Misses        24164    16300    -7864     
+ Partials       5499     4589     -910     

see 3521 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 1dd248a into apache:3.2 Aug 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants