⚡ opt unuse label #13034
Merged
⚡ opt unuse label #13034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
requested changes
Sep 11, 2023
AlbumenJ
requested changes
Sep 13, 2023
...o-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsSupport.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 3.2 #13034 +/- ##
============================================
+ Coverage 67.90% 69.40% +1.49%
+ Complexity 20 2 -18
============================================
Files 1858 1649 -209
Lines 88840 68580 -20260
Branches 14288 10002 -4286
============================================
- Hits 60331 47599 -12732
+ Misses 23154 16398 -6756
+ Partials 5355 4583 -772 see 3507 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
requested changes
Sep 20, 2023
| public static Map<String, String> applicationTags(ApplicationModel applicationModel) { | ||
| return applicationTags(applicationModel, null); | ||
| } | ||
|
|
||
| public static Map<String, String> applicationTags(ApplicationModel applicationModel, @Nullable Map<String, String> extraInfo) { | ||
| Map<String, String> tags = new HashMap<>(); | ||
| tags.put(TAG_IP, getLocalHost()); | ||
| tags.put(TAG_HOSTNAME, getLocalHostName()); | ||
| tags.put(TAG_APPLICATION_NAME, applicationModel.getApplicationName()); | ||
| tags.put(TAG_APPLICATION_MODULE, applicationModel.getInternalId()); | ||
| tags.put(TAG_APPLICATION_VERSION_KEY, version); |
There was a problem hiding this comment.
Version key can be moved into gitTags
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Sep 25, 2023
bert82503
reviewed
Nov 10, 2023
| return tags; | ||
| } | ||
| public static Map<String, String> hostTags( Map<String, String> tags) { | ||
| tags.put(TAG_IP, getLocalHost()); |
There was a problem hiding this comment.
服务方法的指标数据，ip标签为何移走了？是怎么考量的？
某个方法耗时长，怎么反推定位到是某个ip实例触发的？通过traceId定位么
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
remove unuse label : host、ip、gitcommitid
we can get it（host) when discover host such as prometheus use $instance
Brief changelog
Verifying this change
Checklist