Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading process cannot load environment variables. #13091

Conversation

chickenlj
Copy link
Contributor

For example, environment variable DUBBO_REGISTRY_ADDRESS=zookeeper://127.0.0.1:2182 should override same configuration in dubbo.properties dubbo.registry.address=zookeeper://127.0.0.1:2181.

@chickenlj chickenlj changed the base branch from 3.2 to 3.3.0-beta.1-release September 21, 2023 03:28
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13091 (76f9c1f) into 3.3.0-beta.1-release (99ba6e3) will increase coverage by 2.11%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             3.3.0-beta.1-release   #13091      +/-   ##
==========================================================
+ Coverage                   65.46%   67.58%   +2.11%     
==========================================================
  Files                        3712     1791    -1921     
  Lines                      147324    72012   -75312     
  Branches                    20926    10337   -10589     
==========================================================
- Hits                        96451    48666   -47785     
+ Misses                      41274    18610   -22664     
+ Partials                     9599     4736    -4863     

see 1961 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj merged commit cff9bfd into apache:3.3.0-beta.1-release Sep 23, 2023
13 of 14 checks passed
@chickenlj chickenlj deleted the 3.3.0-beta-fix_fail_load_env_variables2 branch September 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants