Only throws exception when exporting service #13217
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.2 #13217 +/- ##
============================================
- Coverage 69.44% 69.42% -0.03%
Complexity 2 2
============================================
Files 1649 1649
Lines 68725 68726 +1
Branches 10014 10015 +1
============================================
- Hits 47728 47711 -17
- Misses 16405 16418 +13
- Partials 4592 4597 +5 see 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| throw new RpcException(throwable); | ||
| try { | ||
| // Stop QoS Server to support re-start if Qos-Check is enabled | ||
| stopServer(); |
There was a problem hiding this comment.
This causes stopServer() only be called when qosCheck=true is met, is this expected?
There was a problem hiding this comment.
Yes. If disable check, we should not retry start in the future.
| } catch (Throwable stop) { | ||
| logger.warn(QOS_FAILED_START_SERVER, "", "", "Fail to stop qos server: ", stop); | ||
| } | ||
| if (isServer) { |
There was a problem hiding this comment.
Why do we need to tell 'export' from 'refer' and only throw exception for 'export', I don't get the intention behind this change.
There was a problem hiding this comment.
In some scenarios, a reference to Dubbo is created when called. If we fail, this will cause the call to fail.
What is the purpose of the change
Brief changelog
Verifying this change
Checklist