Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pom): Exclude unnecessary transitive dependencies for zookeeper #13230

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Oct 18, 2023

What is the purpose of the change

See: #13188

Brief changelog

Exclude the relevant log jars. In a properly configured application, it will directly include the required log jars. Indirectly dependencies can leading to jar version mistake.

Verifying this change

The example app work fine without exclude log jars.
Has been tested with samples:

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean force-pushed the bugfix-13188-exclude-zookeeper-log-jars branch 5 times, most recently from 8eb7cfd to 35259a7 Compare October 20, 2023 01:11
@oxsean oxsean force-pushed the bugfix-13188-exclude-zookeeper-log-jars branch 4 times, most recently from 94919f3 to d150bce Compare October 30, 2023 05:16
@oxsean oxsean requested a review from AlbumenJ October 30, 2023 05:43
@oxsean oxsean force-pushed the bugfix-13188-exclude-zookeeper-log-jars branch from ea6afcc to 63affaa Compare October 30, 2023 14:43
@oxsean oxsean force-pushed the bugfix-13188-exclude-zookeeper-log-jars branch from 63affaa to fa4fa0e Compare October 30, 2023 14:45
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13230 (8bfddfc) into 3.3 (f635de7) will decrease coverage by 27.27%.
Report is 1 commits behind head on 3.3.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                3.3   #13230       +/-   ##
=============================================
- Coverage     67.95%   40.68%   -27.27%     
+ Complexity        8        6        -2     
=============================================
  Files          1727     1726        -1     
  Lines         71282    71276        -6     
  Branches      10292    10292               
=============================================
- Hits          48442    29001    -19441     
- Misses        18143    38110    +19967     
+ Partials       4697     4165      -532     

see 1079 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 539bb11 into apache:3.3 Nov 2, 2023
14 checks passed
@oxsean oxsean deleted the bugfix-13188-exclude-zookeeper-log-jars branch November 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants