Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize AbstractConfigTest #13243

Merged
merged 3 commits into from
Oct 23, 2023
Merged

optimize AbstractConfigTest #13243

merged 3 commits into from
Oct 23, 2023

Conversation

Linchen-Xu
Copy link
Contributor

What is the purpose of the change

optimize AbstractConfigTest

Brief changelog

org.apache.dubbo.config.AbstractConfigTest

  • Rewrite testAppendProperties related tests because AbstractConfig.appendProperties no longer exists.
  • Remove unused inner test class PropertiesConfig.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13243 (943caf5) into 3.2 (be15772) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13243      +/-   ##
============================================
- Coverage     69.51%   69.50%   -0.02%     
  Complexity        2        2              
============================================
  Files          1653     1653              
  Lines         68937    68937              
  Branches      10045    10045              
============================================
- Hits          47919    47912       -7     
- Misses        16387    16389       +2     
- Partials       4631     4636       +5     

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit ad26a69 into apache:3.2 Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants