Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SslServerTlsHandler#decode early return #13468

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

manzhizhen
Copy link

@manzhizhen manzhizhen commented Dec 10, 2023

…ode should remove and return instead of printing the error log.

What is the purpose of the change

When I read part of the Dubbo netty4 source code, I found SslServerTlsHandler#decode method in dealing with "providerConnectionConfig.getAuthPolicy() == AuthPolicy.NONE" not timely return,
this will cause it to print the error log and close connection

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

…ode should remove and return instead of printing the error log.
Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43e513d) 69.59% compared to head (0385da8) 69.49%.
Report is 38 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13468      +/-   ##
============================================
- Coverage     69.59%   69.49%   -0.10%     
  Complexity        2        2              
============================================
  Files          1653     1655       +2     
  Lines         71623    71700      +77     
  Branches      10269    10278       +9     
============================================
- Hits          49847    49830      -17     
- Misses        17083    17162      +79     
- Partials       4693     4708      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 71a1ed3 into apache:3.2 Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants