Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async method call ClassCastException error when requesting go server #13932

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

FoghostCn
Copy link
Contributor

What is the purpose of the change

fix #13931

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@FoghostCn
Copy link
Contributor Author

FoghostCn commented Mar 17, 2024

The same thing is happened at

private static Object call(Invoker<?> invoker, MethodDescriptor methodDescriptor, Object[] arguments) {
RpcInvocation rpcInvocation = new RpcInvocation(
invoker.getUrl().getServiceModel(),
methodDescriptor.getMethodName(),
invoker.getInterface().getName(),
invoker.getUrl().getProtocolServiceKey(),
methodDescriptor.getParameterClasses(),
arguments);
// When there are multiple MethodDescriptors with the same method name, the return type will be wrong
rpcInvocation.setReturnType(methodDescriptor.getReturnClass());

maybe we should find a unified way to solve this problem

@FoghostCn FoghostCn force-pushed the 3.2-bug-fix-async branch 2 times, most recently from 5a1bd65 to 352f53a Compare March 18, 2024 01:57
Copy link

sonarcloud bot commented Mar 18, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (4c59877) to head (aa9214d).
Report is 248 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13932      +/-   ##
==========================================
- Coverage   70.51%   70.45%   -0.06%     
==========================================
  Files        1607     1607              
  Lines       70071    70073       +2     
  Branches    10100    10101       +1     
==========================================
- Hits        49412    49372      -40     
- Misses      16044    16067      +23     
- Partials     4615     4634      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit a342f67 into apache:3.2 Mar 19, 2024
19 checks passed
@FoghostCn FoghostCn deleted the 3.2-bug-fix-async branch March 19, 2024 03:45
Will-well pushed a commit to Will-well/dubbo that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants