Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修正RoundRobin负载均衡方式的bug #14

Closed
wants to merge 6 commits into from
Closed

修正RoundRobin负载均衡方式的bug #14

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5116148
修正weightSequence过快增长导致的高权重机器调用过多问题。currentWeight本应为每轮加一，但原错写为每次调用加一。
zhouym06 Oct 15, 2013
7c25898
clean up
zhouym06 Oct 15, 2013
ea1a36d
clean up
zhouym06 Oct 21, 2013
54111b1
修正weightSequence过快增长导致的高权重机器调用过多问题。currentWeight本应为每轮加一，但原错写为每次调用加一。
zhouym06 Oct 21, 2013
08a2b18
clean up
zhouym06 Oct 21, 2013
6628b71
clean up
zhouym06 Oct 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions ...luster/src/main/java/com/alibaba/dubbo/rpc/cluster/loadbalance/RoundRobinLoadBalance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.dubbo.rpc.cluster.loadbalance;

package com.alibaba.dubbo.rpc.cluster.loadbalance;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
Expand All @@ -24,23 +24,24 @@
import com.alibaba.dubbo.common.utils.AtomicPositiveInteger;
import com.alibaba.dubbo.rpc.Invocation;
import com.alibaba.dubbo.rpc.Invoker;

/**
* Round robin load balance.
*
* @author qian.lei
* @author william.liangf
*/

/**
* Round robin load balance.
*
* @author qian.lei
* @author william.liangf
* @author zhou.yiming
*/
public class RoundRobinLoadBalance extends AbstractLoadBalance {

public static final String NAME = "roundrobin";

private final ConcurrentMap<String, AtomicPositiveInteger> sequences = new ConcurrentHashMap<String, AtomicPositiveInteger>();
public static final String NAME = "roundrobin";
private final ConcurrentMap<String, AtomicPositiveInteger> sequences = new ConcurrentHashMap<String, AtomicPositiveInteger>();

private final ConcurrentMap<String, AtomicPositiveInteger> weightSequences = new ConcurrentHashMap<String, AtomicPositiveInteger>();

protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation invocation) {
String key = invokers.get(0).getUrl().getServiceKey() + "." + invocation.getMethodName();
protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation invocation) {
String key = invokers.get(0).getUrl().getServiceKey() + "." + invocation.getMethodName();
int length = invokers.size(); // 总个数
int maxWeight = 0; // 最大权重
int minWeight = Integer.MAX_VALUE; // 最小权重
Expand All @@ -55,7 +56,16 @@ protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation
weightSequences.putIfAbsent(key, new AtomicPositiveInteger());
weightSequence = weightSequences.get(key);
}
int currentWeight = weightSequence.getAndIncrement() % maxWeight;
int currentWeight;
if(sequences.get(key).get() % length == 0)
{
currentWeight = weightSequence.getAndIncrement() % maxWeight;
}
else
{
currentWeight = weightSequence.get() % maxWeight;
}

List<Invoker<T>> weightInvokers = new ArrayList<Invoker<T>>();
for (Invoker<T> invoker : invokers) { // 筛选权重大于当前权重基数的Invoker
if (getWeight(invoker, invocation) > currentWeight) {
Expand All @@ -69,14 +79,14 @@ protected <T> Invoker<T> doSelect(List<Invoker<T>> invokers, URL url, Invocation
invokers = weightInvokers;
length = invokers.size();
}
}
}
AtomicPositiveInteger sequence = sequences.get(key);
if (sequence == null) {
sequences.putIfAbsent(key, new AtomicPositiveInteger());
sequence = sequences.get(key);
}
// 取模轮循
return invokers.get(sequence.getAndIncrement() % length);
}

}
// 取模轮循
return invokers.get(sequence.getAndIncrement() % length);
}
}