Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Update org.apache.dubbo.dependency.FileTest #14001

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change

Update org.apache.dubbo.dependency.FileTest in 3.3 to support check dubbo-all-shaded and dubbo-core-spi (#13961)

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.54%. Comparing base (55b6d17) to head (d4f43ec).
Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14001      +/-   ##
==========================================
- Coverage   38.54%   38.54%   -0.01%     
==========================================
  Files        1895     1895              
  Lines       79281    79281              
  Branches    11529    11529              
==========================================
- Hits        30562    30555       -7     
- Misses      44443    44451       +8     
+ Partials     4276     4275       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stellar1999
Copy link
Contributor Author

I've checked core-spi and all-shaded just like checked dubbo-all transforms, so I added some transforms in these POM files. I'm not sure if these additions are correct. Should I only check the transforms included in core-spi and all-shaded modules in their dependencies?

@AlbumenJ AlbumenJ merged commit 0788f74 into apache:3.3 Mar 29, 2024
19 checks passed
@Stellar1999 Stellar1999 deleted the feat/file_test_support branch March 29, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants