Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ignore to exclude log files. #14064

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update .ignore to exclude log files. #14064

merged 1 commit into from
Apr 13, 2024

Conversation

Chenjp
Copy link
Contributor

@Chenjp Chenjp commented Apr 11, 2024

Ignore dubbo/dubbo-rpc/dubbo-rpc-api/custom-access.log and its rotated files.

What is the purpose of the change

dubbo/dubbo-rpc/dubbo-rpc-api: Log files - custom-access.log and custom-access.log{YYYYMMDD} changed after TESTS. Make them non-versioned.

Brief changelog

dubbo/dubbo-rpc/dubbo-rpc-api: make custom-access.log and custom-access.log{YYYYMMDD} non-versioned.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Ignore custom-access.log and its rotated files.
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AlbumenJ AlbumenJ merged commit 155c2f2 into apache:3.2 Apr 13, 2024
19 checks passed
@Chenjp
Copy link
Contributor Author

Chenjp commented Apr 15, 2024

@AlbumenJ would you please merge this PR to (apache:3.3)?

@AlbumenJ
Copy link
Member

AlbumenJ commented May 6, 2024

@AlbumenJ would you please merge this PR to (apache:3.3)?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants