-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature 3.3] Triple Rest Cors Support #14073
Conversation
@AlbumenJ LGTM. |
...o-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java
Outdated
Show resolved
Hide resolved
@AlbumenJ PTAL |
@@ -22,5 +22,5 @@ | |||
@SPI(scope = ExtensionScope.FRAMEWORK) | |||
public interface HeaderFilter { | |||
|
|||
RpcInvocation invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException; | |||
void invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that this API was introduced in 3.0. indeed shouldn't be modified, I'll revert it later. However, this return value not being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert have done
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
issue [#13965 ]
I have added a demo test for this new feature to the 3.3-triple-cors branch of the fork's dubbo-sample repository, and used the sample repository to pass ci on my own branch. This is link Rawven#7
Brief changelog
Verifying this change
Checklist