Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature 3.3] Triple Rest Cors Support #14073

Merged
merged 73 commits into from
May 23, 2024
Merged

Conversation

Rawven
Copy link
Contributor

@Rawven Rawven commented Apr 12, 2024

What is the purpose of the change

issue [#13965 ]
I have added a demo test for this new feature to the 3.3-triple-cors branch of the fork's dubbo-sample repository, and used the sample repository to pass ci on my own branch. This is link Rawven#7

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean self-requested a review April 12, 2024 13:59
@oxsean
Copy link
Collaborator

oxsean commented May 20, 2024

@AlbumenJ LGTM.

@Rawven
Copy link
Contributor Author

Rawven commented May 21, 2024

@AlbumenJ PTAL
I have fix the license,but it looks like the latest commit of the integration test will make the workflow fail

@@ -22,5 +22,5 @@
@SPI(scope = ExtensionScope.FRAMEWORK)
public interface HeaderFilter {

RpcInvocation invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException;
void invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this api?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that this API was introduced in 3.0. indeed shouldn't be modified, I'll revert it later. However, this return value not being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert have done

Copy link

sonarcloud bot commented May 22, 2024

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 1f6d441 into apache:3.3 May 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants