Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE will occur when consumer lazy init and the consumer thread contextClassLoader is null #14478

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

Xwiam
Copy link
Contributor

@Xwiam Xwiam commented Jul 29, 2024

What is the purpose of the change

fix the NPE Exception when Hessian2ObjectInput readObject

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@Xwiam
Copy link
Contributor Author

Xwiam commented Jul 29, 2024

#14477 (comment)

@AlbumenJ
Copy link
Member

image

@wcy666103
Copy link
Contributor

Use mvn spotless:apply to format the code.

@Xwiam
Copy link
Contributor Author

Xwiam commented Aug 1, 2024

the code is already formatted.

Copy link

sonarcloud bot commented Aug 1, 2024

@AlbumenJ AlbumenJ merged commit feceeca into apache:3.2 Aug 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants