Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuefix 2218 #2225

Closed
wants to merge 17 commits into from
Closed

Issuefix 2218 #2225

wants to merge 17 commits into from

Conversation

elvis9xu163
Copy link

What is the purpose of the change

bugfix

Brief changelog

fix issue: When using telnet "invoke" method, if there is a [null] param, the response always be [null] #2218

Verifying this change

fixed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

lovepoem and others added 17 commits July 15, 2018 18:23
…-lite  (apache#2073)

* remove hessian-lite
* add hessian-lite dependency to dependencies-bom/pom.xml
…afeLogger.appendContextMessage() > NetUtils.getLocalAddress() (apache#1912)
@carryxyh
Copy link
Member

Check your commit and deal the conflicts first, pls...

@diecui1202
Copy link

@elvis9xu163 Thanks for your contributing. But why this PR has so many commits? Maybe you need to checkout from the lastest master branch. BTW, resolve the conflict.

@elvis9xu163
Copy link
Author

too many conflicts due to based on last release version, i create another pull request based on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.